Code review: Supplier ammo-giving optimization.

[][X][~FLuKE~][X][]

its basically like the platform is removed/destroyed but the collision is still there.

[Feralidragon]

Just checked the code, the problem is obvious.
The platform spawns an hidden collision (because as platform is a pawn, thus it cannot serve as platform as you would keep jumping on it instead of staying), then it uses a simulated non-native event to destroy it (-> unreliable way to destroy actors on client).

Plus, given that the ICH is bNetTemporary=False, it cannot be destroyed in the client, and when you forcefully try (like it is happening now), once the server destroys it, odd things may happen client-side.

Use the native destroyed event to destroy the ICH together with the platform, take out the reference from the ICH to the platform (only the reference platform->ICH is needed) and do it server-side only, and problem solved.

[|uK|Grimreaper]

whatever he said ^

[SAM]

Grim can you stop posting useless spammy posts in constructive discussions like this please?

[|uK|Grimreaper]

huh what i was one of the few people that asked about this bug

[Higor]

Yeah, the platform should be a normal, replicated actor.
That means extra bandwidth but maybe there's another way.

Feralidragon, there's one thing I've been wondering for a long time and never decided to try it out:
On clientside replicated actors, do their PostBeginPlay(), PostNetBeginPlay(), and Destroyed() get called every time they enter relevancy or does that happen once?

If it happens everytime, we could make the platform collision appear in a totally clientside fashion and serve the same purpose the non-replicated collision serverside, then destroy it just like the graphic effects.
As a matter of fact, if the events don't happen, we can just make an extra graphic effect that works as collision so we don't have to rewrite a lot of code.
DELETED TEXT: Stupid statement.

PD: Was the forum domain name hijacked for the last days or two? The site was showing something completely different for me a few hours ago.


EDIT:
I noticed that due to this extra collision, the platform can't take non-explosive damage from above.
I suggest using a workaround so that the platform itself doesn't receive damage, while the collision (which should be bigger both above and below than the actual platform) forwards TakeDamage calls to the platform.

[SAM]

PD: Was the forum domain name hijacked for the last days or two? The site was showing something completely different for me a few hours ago.

No it wasn't. I pointed the NameServers to a wrong IP /amateur mistake.

[Feralidragon]

Feralidragon, there's one thing I've been wondering for a long time and never decided to try it out:
On clientside replicated actors, do their PostBeginPlay(), PostNetBeginPlay(), and Destroyed() get called every time they enter relevancy or does that happen once?

It only happens once.

If it happens everytime, we could make the platform collision appear in a totally clientside fashion and serve the same purpose the non-replicated collision serverside, then destroy it just like the graphic effects.
As a matter of fact, if the events don't happen, we can just make an extra graphic effect that works as collision so we don't have to rewrite a lot of code.

Yes, as long the building runs simulated functions/events, it could just make a Level.NetMode != NM_DedicatedServer and spawn the effects.
Personally I did that a lot, the only reason to not do it is when the spawn context of an effect happens server-side (well, but even for that we can define replicated functions, but most of the times just spawning the effect in the server isn't problematic as long as the actual processing and variables doesn't get replicated as well, which can occupy a lot more bandwidth over time than the spawn alone).

I noticed that due to this extra collision, the platform can't take non-explosive damage from above.
I suggest using a workaround so that the platform itself doesn't receive damage, while the collision (which should be bigger both above and below than the actual platform) forwards TakeDamage calls to the platform.

Yes, that would be the best approach (actually that's pretty much the "always-correct" kind of approach for anything using an external collision hull).

[.seVered.][]

Couldn't we make the regular supplier supply everyone standing in it?

[|uK|B|aZe//.]

what would be the point of having a super sup then